[PATCH] D59780: Support Intel Control-flow Enforcement Technology
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 1 01:50:59 PDT 2019
MaskRay added inline comments.
================
Comment at: lld/test/ELF/Inputs/i386-cet1.s:2
+.section ".note.gnu.property", "a"
+.long 4
+.long 12
----------------
ruiu wrote:
> MaskRay wrote:
> > Missing `.align 4`
> Do you need that? It's not wrong to add that but for the purpose of testing this file is enough, no?
Not required but that would make the tests feel more real.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59780/new/
https://reviews.llvm.org/D59780
More information about the llvm-commits
mailing list