[PATCH] D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant.

[Luqman Aden via Phabricator via llvm-commits]

luqmana added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp-sub.ll:66
+
+define i1 @test7(i64 %x) {
+; CHECK-LABEL: @test7(
----------------
lebedev.ri wrote:
> Would be good to give tests more meaningful names.
> Is this a negative test?
Good point, updated the names. And yup, that is a negative test. I've made it more clear.


================
Comment at: llvm/test/Transforms/InstCombine/icmp-sub.ll:83-85
+  %y = sub nuw i64 10, %x
+  %z = icmp ult i64 %y, 11
+  ret i1 %z
----------------
lebedev.ri wrote:
> This is identical to the previous test.
Good catch, meant to be a different negative test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59916/new/

https://reviews.llvm.org/D59916