[PATCH] D59916: [InstCombine] Combine no-wrap sub and icmp w/ constant.
    Roman Lebedev via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sat Mar 30 14:54:17 PDT 2019
    
    
  
lebedev.ri added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/icmp-sub.ll:66
+
+define i1 @test7(i64 %x) {
+; CHECK-LABEL: @test7(
----------------
Would be good to give tests more meaningful names.
Is this a negative test?
================
Comment at: llvm/test/Transforms/InstCombine/icmp-sub.ll:83-85
+  %y = sub nuw i64 10, %x
+  %z = icmp ult i64 %y, 11
+  ret i1 %z
----------------
This is identical to the previous test.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59916/new/
https://reviews.llvm.org/D59916
    
    
More information about the llvm-commits
mailing list