[PATCH] D60026: ELF: Perform per-section .ARM.exidx processing during combineEhFrameSections(). NFCI.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 30 10:36:48 PDT 2019
grimar added a comment.
I like this approach and see no major issues with this patch probably.
(The way `combineEhSections` works with sections is not very consistent (e.g. the behavior of 'addSection' calls),
but I did not find a nice way to improve it atm, we can change it later I think)
================
Comment at: lld/ELF/Writer.cpp:472
if (!Config->Relocatable)
+ combineEhSections<ELFT>();
----------------
I think it worth to add a comment about what this method does now.
(or perhaps it would be better to add comments to `combineEhSections` body though)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60026/new/
https://reviews.llvm.org/D60026
More information about the llvm-commits
mailing list