[PATCH] D60024: [cmake] Add function for building native tool
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 29 20:04:36 PDT 2019
phosek added inline comments.
================
Comment at: llvm/cmake/modules/CrossCompile.cmake:73
+ # LLVM_OPTIMIZED_TABLEGEN. Always builds in Release.
+ set(one_value_keywords
+ TARGET # The target to build natively
----------------
Since both of these are required, wouldn't it be better to pass them as function arguments (i.e. `function(build_native_tool target output_path_var)`)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60024/new/
https://reviews.llvm.org/D60024
More information about the llvm-commits
mailing list