[PATCH] D60018: [codeview] Remove Type member from CVRecord

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

Nice, does this actually have any performance impact?  Since the arrays are smaller and  have better cache locality.



================
Comment at: llvm/unittests/DebugInfo/CodeView/RandomAccessVisitorTest.cpp:371
   std::vector<CVType> TypeArray;
-  TypeArray.push_back(
-      CVType(static_cast<TypeLeafKind>(Class.Kind), Builder.records()[0]));
-  TypeArray.push_back(
-      CVType(static_cast<TypeLeafKind>(Modifier.Kind), Builder.records()[1]));
+  TypeArray.push_back(CVType(Builder.records()[0]));
+  TypeArray.push_back(CVType(Builder.records()[1]));
----------------
Minor nitpick, but this looks kinda gross to me.  How about:

```
std::vector<CVType> TypeArray = {
  {Builder.records()[0]},
  {Builder.records()[1]}
};
```

I don't feel strongly though, just a suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60018/new/

https://reviews.llvm.org/D60018