[PATCH] D59971: [GlobalISel] Add legalization support for non-power-2 loads and stores

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

In D59971#1448481 <https://reviews.llvm.org/D59971#1448481>, @arsenm wrote:

> In D59971#1447273 <https://reviews.llvm.org/D59971#1447273>, @aemerson wrote:
>
> > Fix alignment for smaller MMO. I couldn't use your suggested getMachineMemOperand() method because it doesn't update the alignment it seems.
>
>
> Are you confusing the alignment and base alignment? I had this problem last time I touched this. getMachineMemOperand should do the right thing


Ah probably. When I changed to using the getMachineMemOperand() function the test still passed, I was expecting the MMO printer to instead print "align 2". It seems it prints the base pointer alignment, not the alignment of the access.

In D59971#1448481 <https://reviews.llvm.org/D59971#1448481>, @arsenm wrote:

> In D59971#1447273 <https://reviews.llvm.org/D59971#1447273>, @aemerson wrote:
>
> > Fix alignment for smaller MMO. I couldn't use your suggested getMachineMemOperand() method because it doesn't update the alignment it seems.
>
>
> Are you confusing the alignment and base alignment? I had this problem last time I touched this. getMachineMemOperand should do the right thing





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59971/new/

https://reviews.llvm.org/D59971