[lld] r357314 - Don't copy the .drective section with std::string
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 29 14:00:22 PDT 2019
Author: rnk
Date: Fri Mar 29 14:00:22 2019
New Revision: 357314
URL: http://llvm.org/viewvc/llvm-project?rev=357314&view=rev
Log:
Don't copy the .drective section with std::string
Both COFF and bitcode input files expose these as stable strings.
Modified:
lld/trunk/COFF/InputFiles.cpp
lld/trunk/COFF/InputFiles.h
Modified: lld/trunk/COFF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/InputFiles.cpp?rev=357314&r1=357313&r2=357314&view=diff
==============================================================================
--- lld/trunk/COFF/InputFiles.cpp (original)
+++ lld/trunk/COFF/InputFiles.cpp Fri Mar 29 14:00:22 2019
@@ -172,7 +172,7 @@ SectionChunk *ObjFile::readSection(uint3
if (Name == ".drectve") {
ArrayRef<uint8_t> Data;
COFFObj->getSectionContents(Sec, Data);
- Directives = std::string((const char *)Data.data(), Data.size());
+ Directives = StringRef((const char *)Data.data(), Data.size());
return nullptr;
}
Modified: lld/trunk/COFF/InputFiles.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/InputFiles.h?rev=357314&r1=357313&r2=357314&view=diff
==============================================================================
--- lld/trunk/COFF/InputFiles.h (original)
+++ lld/trunk/COFF/InputFiles.h Fri Mar 29 14:00:22 2019
@@ -74,12 +74,12 @@ public:
StringRef ParentName;
// Returns .drectve section contents if exist.
- StringRef getDirectives() { return StringRef(Directives).trim(); }
+ StringRef getDirectives() { return Directives; }
protected:
InputFile(Kind K, MemoryBufferRef M) : MB(M), FileKind(K) {}
- std::string Directives;
+ StringRef Directives;
private:
const Kind FileKind;
More information about the llvm-commits
mailing list