[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 29 12:57:56 PDT 2019


anton-afanasyev added a comment.

In D58675#1448112 <https://reviews.llvm.org/D58675#1448112>, @rnk wrote:

> lgtm
>
> I think this is ready. We can adjust the overloads after the fact. I'd like to get the feature in so we can make improvements independently.


Ok, so I'm to commit this and fix three points in the next commit(s):

1. Improve hashing (it's easy).
2. Use json utility.
3. Improve function_ref constructor and delete StringRef("...") explicit casting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58675/new/

https://reviews.llvm.org/D58675





More information about the llvm-commits mailing list