[PATCH] D60002: AMDGPU: Remove dx10-clamp from subtarget features

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 29 11:03:49 PDT 2019


arsenm created this revision.
arsenm added reviewers: rampitec, scott.linder.
Herald added subscribers: jdoerfert, eraman, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.

Since this can be set with s_setreg*, it should not be a subtarget
property. Set a default based on the calling convention, and Introduce
a new amdgpu-dx10-clamp attribute to override this if desired.

      

Also introduce a new amdgpu-ieee attribute to match.

      

The values need to match to allow inlining. I think it is OK for the
caller's dx10-clamp attribute to override the callee, but there
doesn't appear to be the infrastructure to do this currently without
definining the attribute in the generic Attributes.td.

     

Eventually the calling convention lowering will need to insert a mode
switch somewhere for these.


https://reviews.llvm.org/D60002

Files:
  docs/AMDGPUUsage.rst
  lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  lib/Target/AMDGPU/AMDGPUFeatures.td
  lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  lib/Target/AMDGPU/AMDGPUSubtarget.h
  lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
  lib/Target/AMDGPU/SIFoldOperands.cpp
  lib/Target/AMDGPU/SIISelLowering.cpp
  lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
  lib/Target/AMDGPU/SIMachineFunctionInfo.h
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
  test/CodeGen/AMDGPU/amdgcn-ieee.ll
  test/CodeGen/AMDGPU/clamp.ll
  test/CodeGen/AMDGPU/hsa-fp-mode.ll
  test/Transforms/Inline/AMDGPU/inline-amdgpu-dx10.ll
  test/Transforms/Inline/AMDGPU/inline-amdgpu-ieee.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60002.192869.patch
Type: text/x-patch
Size: 30114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190329/4ae3622c/attachment.bin>


More information about the llvm-commits mailing list