[PATCH] D59942: [DebugInfo] Track multiple registers in DbgEntityHistoryCalculator

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I think this looks reasonable. Is there any performance hit?



================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:131
+// Create a clobbering entry and end all open debug value entries
+// for @Var that are described by @RegNo using that entry.
 static void clobberRegEntries(InlinedEntity Var, unsigned RegNo,
----------------
`///`
`\p Var`


================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:161
   if (HistMap.startDbgValue(Var, DV, NewIndex)) {
+    DenseMap<unsigned, bool> TrackedRegs;
+
----------------
Should this be a SmallDenseMap?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59942/new/

https://reviews.llvm.org/D59942