[PATCH] D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header .

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with minor changes.



================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:121
+bool XCOFFObjectFile::isSectionCompressed(DataRefImpl Sec) const {
+  bool ret = false;
+  llvm_unreachable("Not yet implemented!");
----------------
Minor nit: Naming is not consistent (`ret` versus `Result`).


================
Comment at: llvm/lib/ObjectYAML/XCOFFYAML.cpp:17
+#include <cstdint>
+#include <vector>
+
----------------
I am not seeing a need for `<cstdint>` or `<vector>`. At the same time, `<string.h>` should be added for `::memset`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59419/new/

https://reviews.llvm.org/D59419