[PATCH] D59989: [llvm-objcopy]Allow llvm-objcopy to be used on an ELF file with no section headers
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 29 07:10:49 PDT 2019
jhenderson marked 2 inline comments as done.
jhenderson added inline comments.
================
Comment at: test/tools/llvm-objcopy/ELF/copy-after-strip-sections.test:23
+ Content: 'facefeed'
+ AddressAlign: 0x1000
+ Address: 0x1000
----------------
grimar wrote:
> Is this field important?
Not massively, no. But it does force the section to appear at offset 0x1000. I was originally going to check the contents, but I decided not to do that, so I can get rid of it and the Address below.
================
Comment at: test/tools/llvm-objcopy/ELF/copy-after-strip-sections.test:28
+ VAddr: 0x1000
+ PAddr: 0x1000
+ Sections:
----------------
grimar wrote:
> Do you need `PAddr` for this test?
It's not important. Most of our tests just have both. I can remove it and VAddr too, given the other changes.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59989/new/
https://reviews.llvm.org/D59989
More information about the llvm-commits
mailing list