[PATCH] D59958: [llvm-objcopy] Change SHT_NOBITS to SHT_PROBITS for some --set-section-flags

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 29 04:53:06 PDT 2019


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/set-section-flags.test:52
   - Name:            .foo
-    Type:            SHT_PROGBITS
+    Type:            SHT_NOBITS
     Flags:           [ ]
----------------
grimar wrote:
> Would it be better to introduce a new section `.foo` with `SHT_NOBITS`?
I mean a new section '.bar' :) Sorry. I.e. To add a section instead of changing the existent one in a test.
(The same applies for the 'rename-section-flag.test', btw).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59958/new/

https://reviews.llvm.org/D59958





More information about the llvm-commits mailing list