[PATCH] D59946: [llvm-readobj] Improve error message for for --string-dump

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:382
+                    reportError(EI.message());
+                  });
 }
----------------
grimar wrote:
> The code is still different from original, why?
> (I am not against this renaming, but ideally, such things should be done in an NFC commits I think.)
> So if there are no reasons for that, please revert.
Sorry, I was not clear I guess.
1) I am not against the renaming EC->Err in a different patch/commit.
2) The current change affects how the functor is called (i.e. removes the reference), what is also seems like an improvement, but it is not relative to this patch still.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59946/new/

https://reviews.llvm.org/D59946