[PATCH] D59951: [NFC][llvm-exegesis] Refactor Analysis::SchedClassCluster::measurementsMatch()

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D59951#1447500 <https://reviews.llvm.org/D59951#1447500>, @courbet wrote:

> Thanks Roman.


Thank you for the speedy review.

>> This isn't 100% a NFC, because previously for inverse throughput we used `min()`. I have asked whether i have done that correctly in
> 
> https://reviews.llvm.org/D57647?id=184939#inline-510384 but did not hear back. I think `avg()` should be used too, thus it is a fix.
> 
> It should not matter if we assume that the output from the `NumIterations` measurements is accurate enough, so that's fine.

Yes, that is what i thought, too. (median would be better, but avg is pretty good too.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59951/new/

https://reviews.llvm.org/D59951