[PATCH] D59251: [Documentation] Proposal for plan to change variable names

Csaba Dabis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 07:51:26 PDT 2019


Charusso added inline comments.


================
Comment at: llvm/docs/Proposals/VariableNames.rst:86
+[TurnerCamelBack]_.
+Approval for ``lower_case`` was expressed by [CarruthLower]_
+[CarruthCamelBack]_ [TurnerLLDB]_.
----------------
michaelplatings wrote:
> rupprecht wrote:
> > I also prefer this type... you //could// add my name here, but maybe I should ask more generally: it's good that the discussion points in favor/against each style are listed, but as far as individuals that approve/oppose a style, do we plan to run some kind of poll and go with whichever has a majority vote? (Should Chandler/Chris get more votes than me? :) )
> Yes, some kind of poll. Exactly how we do this is to be decided. @Charusso has pointed out https://reviews.llvm.org/vote/ but as we in the UK are painfully aware right now, giving people binary choices can lead to no choice at all. I'm inclined to copy Debian's voting method: https://www.debian.org/vote/
> How we weight the voting is another interesting question. You could say more contributions = more weight, but given that we're specifically interested in the views of newcomers here that doesn't really work. On the other hand, 1 vote per person would mean that one person could get all their friends to vote for them which is even worse. Potentially we could give 1 vote to any person who has contributed before the discussion started.
There you could fill 10 different options on-the-fly: https://reviews.llvm.org/vote/create/ and that is the common place across all the sub-projects. Immediately you could check-out this weight idea of a contributor. I see no problem with that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59251/new/

https://reviews.llvm.org/D59251





More information about the llvm-commits mailing list