[PATCH] D59946: [llvm-readobj] Improve error message for for --string-dump

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer marked an inline comment as done.
StephenTozer added inline comments.


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:378
 
-void error(Error EC) {
-  if (!EC)
+void error(Error Err) {
+  if (!Err)
----------------
grimar wrote:
> You renamed `EC`->`Err` here, but the code below still use `EC` and this renaming
> does not seem necessary (it looks as NFC). Not sure why it was done?
Leftover change from a previous edit of the function that was undone; the reason behind the rename however is that "EC" is short for Error Code; "Err" is the generic name for Error variables.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59946/new/

https://reviews.llvm.org/D59946