[PATCH] D59965: [llvm-readelf] Allow prefix flags for -p and -x

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two small comment nits.



================
Comment at: llvm/test/tools/llvm-readobj/hexdump.test:7
+
+// Test that the -j alias can be used flexibly. Create a baseline and ensure
+// all other combinations are identical.
----------------
-j -> -x?


================
Comment at: llvm/test/tools/llvm-readobj/string-dump.test:1
 # Check the dumping of a section as strings.
 # RUN: yaml2obj %s > %t
----------------
Might be worth adding a comment to say that you're testing the various different ways of specifying the switches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59965/new/

https://reviews.llvm.org/D59965