[PATCH] D59958: [llvm-objcopy] Change SHT_NOBITS to SHT_PROBITS for some --set-section-flags
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 29 02:45:20 PDT 2019
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:107
+ SectionFlag::SecRom | SectionFlag::SecDebug))
+ Sec.Type = SHT_PROGBITS;
+}
----------------
Won't this change the type of other non-NOBITS sections (e.g. SHT_RELA or SHT_DYNSYM)? Is that intended (I suspect not...)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59958/new/
https://reviews.llvm.org/D59958
More information about the llvm-commits
mailing list