[PATCH] D59633: [PowerPC] Look through copies for compare elimination

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 20:10:53 PDT 2019


nemanjai added a comment.

In D59633#1446706 <https://reviews.llvm.org/D59633#1446706>, @jsji wrote:

> Might miss some opportunity related to parameters instead. Please have a look. Thanks.


Thank you so much for catching this. This was just a dumb oversight on my part. I originally had something along these lines and changed it because `getUniqueVRegDef()` won't assert on physical registers. However, I unfortunately changed it after I ran my usual bootstrap tests with lit and test-suite and just prior to posting.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59633/new/

https://reviews.llvm.org/D59633





More information about the llvm-commits mailing list