[PATCH] D59969: [llvm-readobj] Add some generic notes (e.g. NT_VERSION)

Thu Mar 28 17:11:12 PDT 2019

rupprecht marked 2 inline comments as done.
rupprecht added inline comments.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3522
+      {ELF::NT_GNU_BUILD_ATTRIBUTE_OPEN, "OPEN"},
+      {ELF::NT_GNU_BUILD_ATTRIBUTE_FUNC, "func"},
+  };
----------------
MaskRay wrote:
> Is the lowercase used here intentional?
yup

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f=binutils/readelf.c;h=ae1cda9a7bd54b85f085d1bb48f8b2c4bf5f0d46;hp=f221cce32a948b489977cc3199f5da1a66413fb3;hb=6f156d7a4ad1c245b357dc50f63f3564d397839e;hpb=9f757bf7fcb8834ead780e0c4a76d6029b1402c2

I don't know why.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59969/new/

https://reviews.llvm.org/D59969