[PATCH] D57493: [RISCV] Put data smaller than eight bytes to small data section

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/RISCV/RISCVTargetObjectFile.cpp:17
 
+static unsigned SSThreshold = 8;
+
----------------
This isn't thread-safe.


================
Comment at: lib/Target/RISCV/RISCVTargetObjectFile.cpp:63
+  if (GVA->hasLocalLinkage())
+    return false;
+
----------------
We never put variables with internal linkage into a small data section? That seems a little weird.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57493/new/

https://reviews.llvm.org/D57493