[PATCH] D59898: [LCG] Add aliased functions as LCG roots

[Guozhi Wei via Phabricator via llvm-commits]

Carrot updated this revision to Diff 192705.
Carrot marked 4 inline comments as done.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59898/new/

https://reviews.llvm.org/D59898

Files:
  lib/Analysis/LazyCallGraph.cpp
  test/Analysis/LazyCallGraph/alias.ll


Index: test/Analysis/LazyCallGraph/alias.ll
===================================================================
--- test/Analysis/LazyCallGraph/alias.ll
+++ test/Analysis/LazyCallGraph/alias.ll
@@ -0,0 +1,41 @@
+; RUN: opt -disable-output -passes=print-lcg %s 2>&1 | FileCheck %s
+;
+; Aliased function should be reachable in CGSCC.
+
+target triple = "x86_64-grtev4-linux-gnu"
+
+; CHECK:        Edges in function: foo
+; CHECK:        Edges in function: bar
+; CHECK:        Edges in function: baz
+
+; CHECK:        RefSCC with 1 call SCCs:
+; CHECK-NEXT:     SCC with 1 functions:
+; CHECK-NEXT:       bar
+
+; CHECK:       RefSCC with 1 call SCCs:
+; CHECK-NEXT:    SCC with 1 functions:
+; CHECK-NEXT:      foo
+
+; CHECK-NOT:       baz
+
+ at alias1 = weak dso_local alias i8* (i8*), i8* (i8*)* @foo
+
+; Function Attrs: nounwind uwtable
+define dso_local i8* @foo(i8* %returned) {
+  ret i8* %returned
+}
+
+ at alias2 = weak dso_local alias i8* (i8*), i8* (i8*)* @bar
+
+; Function Attrs: nounwind uwtable
+define internal i8* @bar(i8* %returned) {
+  ret i8* %returned
+}
+
+; Internal alias is not reachable.
+ at alias3 = internal alias i8* (i8*), i8* (i8*)* @baz
+
+; Function Attrs: nounwind uwtable
+define internal i8* @baz(i8* %returned) {
+  ret i8* %returned
+}
Index: lib/Analysis/LazyCallGraph.cpp
===================================================================
--- lib/Analysis/LazyCallGraph.cpp
+++ lib/Analysis/LazyCallGraph.cpp
@@ -172,6 +172,19 @@
     addEdge(EntryEdges.Edges, EntryEdges.EdgeIndexMap, get(F), Edge::Ref);
   }
 
+  // Externally visible aliases of internal functions are also viable entry
+  // edges to the module.
+  for (auto &A : M.aliases()) {
+    if (A.hasLocalLinkage())
+      continue;
+    if (Function* F = dyn_cast<Function>(A.getAliasee())) {
+      LLVM_DEBUG(dbgs() << "  Adding '" << F->getName()
+                        << "' with alias '" << A.getName()
+                        << "' to entry set of the graph.\n");
+      addEdge(EntryEdges.Edges, EntryEdges.EdgeIndexMap, get(*F), Edge::Ref);
+    }
+  }
+
   // Now add entry nodes for functions reachable via initializers to globals.
   SmallVector<Constant *, 16> Worklist;
   SmallPtrSet<Constant *, 16> Visited;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59898.192705.patch
Type: text/x-patch
Size: 2230 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190328/689a7877/attachment.bin>