[PATCH] D59790: [DebugInfo][Docs] Document how variable location metadata is transformed through target codegen

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

I have not read through everything yet, but thanks for documenting this!



================
Comment at: docs/SourceLevelDebugging.rst:550
+metadata is attached to SDNodes in SelectionDAGs. After instruction selection
+has occurred and a MIR function created, if the SDNode associated with debug
+metadata is allocated a virtual register, that virtual register is used as the
----------------
nit: function //is// created


================
Comment at: docs/SourceLevelDebugging.rst:575
+
+The position at which the DBG_VALUEs are inserted should correspond to the
+positions of their matching ``llvm.dbg.value`` intrinsics in the IR block.
----------------
Is it worth mentioning that there are some exceptions with parameter debug values (`ArgDbgValues`), or is that too detailed?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59790/new/

https://reviews.llvm.org/D59790