[PATCH] D59928: [MCA] Add an experimental MicroOpQueue stage.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb marked 3 inline comments as done.
andreadb added inline comments.


================
Comment at: include/llvm/MCA/Context.h:42
+  unsigned MicroOpQueueSize;
+  unsigned DecodersThroughput;
   unsigned DispatchWidth;
----------------
courbet wrote:
> Maybe add a comment: `// Instructions per cycle.`
> 
Sure. I will add that comment.


================
Comment at: include/llvm/MCA/Stages/MicroOpQueueStage.h:44
+  // doesn't fit in the buffer.
+  const unsigned BufferSize;
+
----------------
courbet wrote:
> This duplicates Buffer.size(), what about removing it or making it an accessor  ?
Good point. I will remove it. I will move that code comment to method `getNormalizedOpcodes`.


================
Comment at: tools/llvm-mca/llvm-mca.cpp:110
+    DecoderThroughput("decoder-throughput", cl::Hidden,
+                      cl::desc("Maximum throughput from the decoders"),
+                      cl::cat(ToolOptions), cl::init(0));
----------------
courbet wrote:
> This can be understood as input (instructions) or output (uops) throughput, so I think we should clarify: `Maximum throughput from the decoders (instructions per cycle)`
I will change it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59928/new/

https://reviews.llvm.org/D59928