[PATCH] D59912: [x86] flatten packss+movmsk into 256-bit movmsk

[Sanjay Patel via Phabricator via llvm-commits]

spatel planned changes to this revision.
spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/test/CodeGen/X86/bitcast-and-setcc-256.ll:205
 ; AVX2-NEXT:    vpand %ymm1, %ymm0, %ymm0
-; AVX2-NEXT:    vextracti128 $1, %ymm0, %xmm1
-; AVX2-NEXT:    vpacksswb %xmm1, %xmm0, %xmm0
-; AVX2-NEXT:    vpmovmskb %xmm0, %eax
+; AVX2-NEXT:    vpmovmskb %ymm0, %eax
 ; AVX2-NEXT:    # kill: def $ax killed $ax killed $eax
----------------
RKSimon wrote:
> I don't think this is going to work - we end up with a movmsk of a 32i8 (i32 instead of a i16 zext).
Argh...yes, this is wrong. I need to rethink this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59912/new/

https://reviews.llvm.org/D59912