[PATCH] D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Two nits, otherwise LGTM.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:678
+    IsDefault = false;
+    return StringRef("");
+  }
----------------
I don't think you need to be explicit here. String literals should harmlessly convert to `StringRef`.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:699
+    reportError("Invalid string offset");
+  return StringRef(StrTab.data() + NameOffset);
+}
----------------
Ditto. Not sure you need to be explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59545/new/

https://reviews.llvm.org/D59545