[PATCH] D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs).
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 28 04:10:37 PDT 2019
RKSimon requested changes to this revision.
RKSimon added a reviewer: RKSimon.
RKSimon added a comment.
Some style changes
================
Comment at: llvm/lib/Target/X86/X86MacroFusion.cpp:29
+ SPO,
+ Invalid,
+};
----------------
(style) Please comment enums - they are not obvious.
================
Comment at: llvm/lib/Target/X86/X86MacroFusion.cpp:212
+
+ llvm_unreachable("");
}
----------------
Add a unreachable message
================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.h:40
+ // This indicates the CPU is 64 bit capable not that we are in 64-bit
+ // mode.
+ X86::Feature64Bit,
----------------
NFC change - commit separetely
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59872/new/
https://reviews.llvm.org/D59872
More information about the llvm-commits
mailing list