[PATCH] D59875: [yaml2obj][obj2yaml] - Teach yaml2obj/obj2yaml tools about STB_GNU_UNIQUE symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.

The way symbols are handled in yaml2obj looks like it's desperately in need of an overhaul. It looks very fragile and easy to miss one thing when modifying it like you did here. That's a separate issue though.



================
Comment at: tools/obj2yaml/elf2yaml.cpp:268
     default:
       llvm_unreachable("Unknown ELF symbol binding");
     }
----------------
Sounds to me like llvm_unreachable here is wrong, because it is reachable by any value not recognised. It should just be a normal error saying what the unknown binding value is. That can be a separate patch though if you want.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59875/new/

https://reviews.llvm.org/D59875