[PATCH] D58950: [PowerPC] Strength reduction of multiply by a constant by shift and add/sub in place

[Zixuan Wu via Phabricator via llvm-commits]

wuzish marked 2 inline comments as done.
wuzish added a comment.

Gentle pin.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14591
+
+      // The cycles of related operation are showed as a table above.
+      // Only do (mul x, -(2^N + 1)) => -(add (shl x, N), x) for vector type.
----------------
jsji wrote:
> wuzish wrote:
> > jsji wrote:
> > > These are for P9 right? I believe P8 is different no?
> > Hmm, well. Actually I only have cycles information table about P9, so we can only do for P9 and leave P8 as TODO, and also change comments into `// TODO: enhance the condition for subtarget before pwr9`
> OK for me.
I actually find P8 cycles information and update related test result to accept P8.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58950/new/

https://reviews.llvm.org/D58950