[PATCH] D54583: PowerPC: Optimize SPE double parameter calling setup

[Justin Hibbits via Phabricator via llvm-commits]

jhibbits added a comment.

@kthomsen can you create a new revision just for that diff?



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:3165
+  unsigned i;
+  for (i = 0; i < sizeof(HiRegList) / sizeof(HiRegList[0]); ++i)
+    if (HiRegList[i] == Reg)
----------------
nemanjai wrote:
> I think it is more obvious to use `sizeof(MCPhysReg)` rather than `sizeof(HiRegList[0])`.
This is often spelled out in a macro as nitems(), or sizeofArray() (or similar).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54583/new/

https://reviews.llvm.org/D54583