[PATCH] D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options.

pierre gousseau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 27 08:10:37 PDT 2019


pgousseau marked 4 inline comments as done.
pgousseau added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:575
+                   bool UseAfterScope = false, bool InvalidPointerCmp = false,
+                   bool InvalidPointerSub = false)
+      : UseAfterScope(UseAfterScope || ClUseAfterScope),
----------------
morehouse wrote:
> These parameter lists are getting too long.  Do we need to store the options or can we just check `ClInvalidPointer*` instead?  Or, can we use an options struct?
Yes the parameter are not necessary, I have removed them thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59220/new/

https://reviews.llvm.org/D59220





More information about the llvm-commits mailing list