[PATCH] D59825: SafepointIRVerifier port to new Pass Manager

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: include/llvm/IR/SafepointIRVerifier.h:41
+
+  PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+  PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
----------------
skatkov wrote:
> fedor.sergeev wrote:
> > Why do we need Module wrapper for this?
> > Seems like function pass is enough.
> This is done to similarity to VerifierPass which implements both Module and Function pass functionality. I agree that this pass does not do any verification on Module level but I do not see any issues with keeping both wrappers.
There is no need for additional wrapper.
We already have module->function adaptors and it applies automatically when you specify
  -passes='verify<safepoint-ir>'
So from usability point of view there is no utility in adding this wrapper.

VerifierPass calls verifyModule for Module version and verifyFunction for Function version, so its not just a wrapper.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59825/new/

https://reviews.llvm.org/D59825