[PATCH] D59823: [llvm-readelf]Merge dynamic and static relocation printing to avoid code duplication

Tue Mar 26 20:36:37 PDT 2019

Higuoxing accepted this revision.
Higuoxing added a comment.

LGTM

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2601
     const Elf_Shdr *Sec = unwrapOrError(
         Obj->getSection(Sym, SymTab, this->dumper()->getShndxTable()));
     TargetName = unwrapOrError(Obj->getSectionName(Sec));
----------------
Shall we make `this->dumper()` into local variable? Because I noticed `this->dumper()` in `printRelocation()` and `printDynamicRelocation()` are used twice. But I don't mind. 

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59823/new/

https://reviews.llvm.org/D59823