[PATCH] D59825: SafepointIRVerifier port to new Pass Manager

[Serguei Katkov via Phabricator via llvm-commits]

skatkov planned changes to this revision.
skatkov marked 2 inline comments as done.
skatkov added inline comments.


================
Comment at: include/llvm/IR/SafepointIRVerifier.h:41
+
+  PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+  PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
----------------
fedor.sergeev wrote:
> Why do we need Module wrapper for this?
> Seems like function pass is enough.
This is done to similarity to VerifierPass which implements both Module and Function pass functionality. I agree that this pass does not do any verification on Module level but I do not see any issues with keeping both wrappers.


================
Comment at: lib/Passes/PassRegistry.def:220
 FUNCTION_PASS("reassociate", ReassociatePass())
+FUNCTION_PASS("verify-safepoint-ir", SafepointIRVerifierPass())
 FUNCTION_PASS("scalarizer", ScalarizerPass())
----------------
fedor.sergeev wrote:
> Just a few lines below there are a handful of verifiers.
> They seem to be using a text pipeline format of "verify<something>".
> 
> Lets do this as "verify<safepoint-ir>"
> 
> (and move it down there)
I preferred to keep the same name as Legacy pass manager used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59825/new/

https://reviews.llvm.org/D59825