[PATCH] D59795: [DAGCombine] Improve Lifetime node chains.

[Nirav Dave via Phabricator via llvm-commits]

niravd marked 3 inline comments as done.
niravd added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15585
-    Chains.pop_back();
-    if (!Chain.hasOneUse())
-      continue;
----------------
courbet wrote:
> I have a hard time convincing myself that we can omit this check. Can you add a comment to the code to explain why ?
It's not strictly; we could accidentally skip a store because the TokenFactors aren't properly minimized. There needs to be an extra check that the found store is the last semantically meaningful before the LIFETIME_END. I'll factor this out separately from the chain improvement logic. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59795/new/

https://reviews.llvm.org/D59795