[PATCH] D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/Transforms/GVN/non-integral-pointers.ll:184
 ; Can't forward as the load might be dead.  (Pretend we wrote out the alwaysfalse idiom above.)
-define i8 addrspace(4)* @neg_forward_memcopy(i8 addrspace(4)* addrspace(4)* %loc) {
+define i64 addrspace(4)* @neg_forward_memcopy(i64 addrspace(4)* addrspace(4)* %loc) {
 ; CHECK-LABEL: @neg_forward_memcopy(
----------------
Please revert the type change on this test.  Feel free to add a separate test with the i64 type.

Actually, your test diffs in general are confusing.  Please land your tests, and then rebase on top of them so that changes are visible.  Please do NOT change existing tests without cause.  


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59730/new/

https://reviews.llvm.org/D59730