[PATCH] D59837: Add "git llvm revert" subcommand

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

Thank you for the patch!



================
Comment at: llvm/utils/git-svn/git-llvm:115
+    quoted_cmd = ["'%s'" % arg for arg in cmd]
+    log_verbose('Running in %s: %s' % (cwd, ' '.join(quoted_cmd)))
 
----------------
Nit, perhaps we should use the idiom from https://stackoverflow.com/a/1070756


================
Comment at: llvm/utils/git-svn/git-llvm:429
+    else:
+      log_verbose('Searching by git hash for commit ' + args.revision)
+      # Ignore errors so we can print a friendlier message. Also, use a format
----------------
Is being able to do `git svn revert <git hash>` really that useful?  It looks like it's basically the same as `git revert <git hash>`?

In fact I wonder if what we really want is `git svn lookup` that looks up the hash of an svn rev.  Then you can do `git revert $(git svn lookup r12345)`.  That's more unix-y / more composible.

WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59837/new/

https://reviews.llvm.org/D59837