[PATCH] D58877: [InstCombine] fold add(add(A, ~B), 1) -> sub(A, B)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 13:31:43 PDT 2019


lebedev.ri added a comment.

In D58877#1439691 <https://reviews.llvm.org/D58877#1439691>, @deadalnix wrote:

> Is someone of a different opinion than @spatel ? If not, I'll abandon this patch soon.


I haven't tried this on a whole llvm stage-2 build, but on small-ish codebase i have tried this does not seem to be reachable.
(You could, of course, try stage-2 build, that will have more coverage.)
Sorry for lost effort, i should have seen that `-reassociate` would have solved this :(


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58877/new/

https://reviews.llvm.org/D58877





More information about the llvm-commits mailing list