[PATCH] D54802: [LLD][COFF] Generate import modules in PDB

Tue Mar 26 12:58:25 PDT 2019

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!

In D54802#1440864 <https://reviews.llvm.org/D54802#1440864>, @santagada wrote:

> Anything missing for this to be accepted? It seems like this patch is ready.

I just missed the update, sorry.

================
Comment at: COFF/Writer.cpp:307
   Other->Chunks.clear();
+  ContribSections.insert(ContribSections.end(), Other->ContribSections.begin(), Other->ContribSections.end());
+  Other->ContribSections.clear();
----------------
Needs wrapping

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54802/new/

https://reviews.llvm.org/D54802