[PATCH] D59411: [LLD][COFF] Improve checkFailIfMismatch

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 12:45:30 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/DriverUtils.cpp:708
   if (!Existing.first.empty() && V != Existing.first) {
+    StringRef CmdLine = "cmd-line";
+    std::string SourceStr = Source ? toString(Source) : CmdLine;
----------------
Remove this variable and directly use "cmd-line" instead.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59411/new/

https://reviews.llvm.org/D59411





More information about the llvm-commits mailing list