[PATCH] D59830: [FPEnv] Make constrained FP IR verification more flexible.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 11:53:59 PDT 2019


arsenm added a comment.

In D59830#1443352 <https://reviews.llvm.org/D59830#1443352>, @arsenm wrote:

> In D59830#1443346 <https://reviews.llvm.org/D59830#1443346>, @kpn wrote:
>
> > No new observable behavior change is introduced by this patch. I believe the existing constrained intrinsic tests should exercise it pretty well. Is there a specific test that is needed?
>
>
> I grepped around and don't see these error messages in any verifier tests, so it seems like this isn't actually tested now


At least 2 of these cases are missing tests: https://llvm.org/reports/coverage/lib/IR/Verifier.cpp.gcov.html


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59830/new/

https://reviews.llvm.org/D59830





More information about the llvm-commits mailing list