[PATCH] D59825: SafepointIRVerifier port to new Pass Manager

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

Please, update verify-safepoint tests to use new-pass-manager flavor.



================
Comment at: include/llvm/IR/SafepointIRVerifier.h:41
+
+  PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+  PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
----------------
Why do we need Module wrapper for this?
Seems like function pass is enough.


================
Comment at: lib/Passes/PassRegistry.def:220
 FUNCTION_PASS("reassociate", ReassociatePass())
+FUNCTION_PASS("verify-safepoint-ir", SafepointIRVerifierPass())
 FUNCTION_PASS("scalarizer", ScalarizerPass())
----------------
Just a few lines below there are a handful of verifiers.
They seem to be using a text pipeline format of "verify<something>".

Lets do this as "verify<safepoint-ir>"

(and move it down there)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59825/new/

https://reviews.llvm.org/D59825