[PATCH] D59518: [DwarfDebug] Skip entries to big for 16 bit size field in Dwarf < 5.

Tue Mar 26 10:17:50 PDT 2019

dblaikie added a comment.

In D59518#1443166 <https://reviews.llvm.org/D59518#1443166>, @probinson wrote:

> > Out of curiosity, because I can't quite spot it - where is this part of debug_loc defined in DWARFv4? I don't see any mention of a location description being prepended by its length there - but I'm guessing I'm misreading/missing it in there somewhere.
>
> No, it's just spectacularly hard to find.  In the v4 spec this tidbit is hidden away in section 7.7.3, second paragraph.  "A location list entry consists of two address offsets followed by a 2-byte length, followed by a block of contiguous bytes that contains a DWARF location description."

Ah, thanks!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59518/new/

https://reviews.llvm.org/D59518