[PATCH] D59816: [Support] Implement zlib independent crc32 computation

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 09:31:12 PDT 2019


evgeny777 added a comment.

> It doesn't matter, at most a single memory fence is necessary.

Yep. However, you don't have it in your code. The `volatile int crc_tbl_inited` prevents compiler optimizations but doesn't prevent out-of-order execution as far as I know.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59816/new/

https://reviews.llvm.org/D59816





More information about the llvm-commits mailing list