[PATCH] D30471: [SDAG] Relax conditions under stores of loaded values can be merged

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 07:29:36 PDT 2019


jyknight added a comment.

Not sure if the PPC issue was a different one, but the commit that reverted this was:

  Revert "[SDAG] Relax conditions under stores of loaded values can be merged"
  
  This reverts r302712.
  
  The change fails with ASAN enabled:
  
  ERROR: AddressSanitizer: use-after-poison on address ... at ...
  READ of size 2 at ... thread T0
    #0 ... in llvm::SDNode::getNumValues() const <snip>/include/llvm/CodeGen/SelectionDAGNodes.h:855:42
    #1 ... in llvm::SDNode::hasAnyUseOfValue(unsigned int) const <snip>/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7270:3
    #2 ... in llvm::SDValue::use_empty() const <snip> include/llvm/CodeGen/SelectionDAGNodes.h:1042:17
    #3 ... in (anonymous namespace)::DAGCombiner::MergeConsecutiveStores(llvm::StoreSDNode*) <snip>/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12944:7
  
  Reviewers: niravd
  
  Subscribers: llvm-commits
  
  Differential Revision: https://reviews.llvm.org/D33081
  
  llvm-svn: 302746


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D30471/new/

https://reviews.llvm.org/D30471





More information about the llvm-commits mailing list