[PATCH] D59816: [Support] Implement zlib independent crc32 computation

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: include/llvm/Support/CRC.h:22
+// zlib independent CRC32 calculation.
+uint32_t getCRC32(uint32_t CRC, StringRef S);
+} // end namespace llvm
----------------
evgeny777 wrote:
> lebedev.ri wrote:
> > I'm not sure if oss-fuzz builds llvm with zlib or not, but if it **does**,
> > this is a *great* fuzzing target, to cross-check with the zlib output.
> LLVM_ENABLE_ZLIB is ON by default, so whether LLVM is built with zlib support or not depends on HAVE_ZLIB_H.
> Are you suggesting something like `llvm-crc32-fuzzer`?
I guess this is a question of naming. I'd say:
`llvm-crc32-fuzzer` would be one to simply run this code only. 
`llvm-llvmcrc32-vs-zlibcrc32-fuzzer` would run this code, the equivalent zlib code, and assert that they returned the same.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59816/new/

https://reviews.llvm.org/D59816