[PATCH] D54647: [WebAssembly] Initial implementation of PIC code generation

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 17:14:45 PDT 2019


dschuff accepted this revision.
dschuff added a comment.

still LGTM. In a followup CL it should be straightforward to add back fast-isel and you might be able to re-use the same checks in load-store-pic.ll. (but you wouldn't need to add fast-isel+PIC to address-offsets.ll because that's testing an optimization that fast-isel doesn't do.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54647/new/

https://reviews.llvm.org/D54647





More information about the llvm-commits mailing list