[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 15:00:20 PDT 2019


mstorsjo added a comment.

In D59797#1442365 <https://reviews.llvm.org/D59797#1442365>, @rnk wrote:

> I used the VS memory profiling tool and used the type view to see the most commonly allocated types. "void" just means allocations whose type wasn't determined, and a lot of it comes from vectors, specifically the new `RelocTargets` vector @mstorsjo added.


Since that vector isn't needed at all for x86, I guess it should be possible to skip it altogether there. It'll complicate the code a little bit, and the conditional might cost a little bit of runtime, but that'd give you back a lot as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59797/new/

https://reviews.llvm.org/D59797





More information about the llvm-commits mailing list